Rename preprocess method#52
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors path resolution in VideoSegmentationSam3Text by renaming the preprocessing helper and invoking it at the start of chunk processing.
Changes:
- Renames
preprocesstoresolvePaths. - Calls
resolvePathsfromprocessChunkbefore the segmentation logic runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
VideoSegmentationSam3Textnode inmeshroom/imageSegmentation/VideoSegmentationSam3Text.pyto improve code clarity and ensure path resolution occurs earlier in the processing pipeline. The most important changes are:Refactoring and Code Organization:
preprocessmethod toresolvePathsin theVideoSegmentationSam3Textclass for clearer intent and maintainability.Processing Logic Improvements:
resolvePathsmethod at the beginning of theprocessChunkmethod to ensure input paths are resolved before processing each chunk.