-
Notifications
You must be signed in to change notification settings - Fork 162
Skip commented lines for model generation #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Darshan N <[email protected]>
Summary of ChangesHello @Darshan174, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where YAML parsing failed during model generation due to the presence of leading comments, such as copyright headers, in YAML files. By adding a new utility function to strip these comments and applying it within the GitHub package generator, the change ensures that YAML manifests are processed without errors, leading to more robust and reliable component generation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a StripLeadingComments function to handle YAML files with leading comments, like copyright headers, which previously caused parsing errors. The implementation of this new function has a bug where it fails to correctly handle files that consist entirely of comments or empty lines, returning the original content instead of an empty slice. I've provided a fix for this issue. The rest of the changes, which apply this function before parsing CRDs, are correct and well-implemented.
Signed-off-by: Darshan N <[email protected]>
Description
fixes YAML parsing errors caused by copyright headers in model generation
Added StripLeadingComments function to remove leading comment lines (like copyright headers) from YAML content before parsing. This prevents parsing failures, such as Knative with Apache License headers.

File: https://github.com/knative/eventing/blob/main/config/core/resources/apiserversource.yaml

The fix is applied in the GitHub package generator where YAML documents are split and processed, ensuring all CRD parsing uses cleaned content.
Notes for Reviewers
Signed commits