Skip to content

Conversation

@Darshan174
Copy link
Contributor

@Darshan174 Darshan174 commented Nov 14, 2025

Description

fixes YAML parsing errors caused by copyright headers in model generation

Added StripLeadingComments function to remove leading comment lines (like copyright headers) from YAML content before parsing. This prevents parsing failures, such as Knative with Apache License headers.
Screenshot 2025-11-14 at 18 16 46

File: https://github.com/knative/eventing/blob/main/config/core/resources/apiserversource.yaml
Screenshot 2025-11-14 at 18 18 08

The fix is applied in the GitHub package generator where YAML documents are split and processed, ensuring all CRD parsing uses cleaned content.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Darshan N <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Darshan174, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where YAML parsing failed during model generation due to the presence of leading comments, such as copyright headers, in YAML files. By adding a new utility function to strip these comments and applying it within the GitHub package generator, the change ensures that YAML manifests are processed without errors, leading to more robust and reliable component generation.

Highlights

  • New Utility Function: Introduced a new StripLeadingComments function in files/sanitization.go to effectively remove leading comment lines (those starting with '#') and empty lines from YAML content.
  • YAML Parsing Fix: Integrated the StripLeadingComments function into the GitHubPackage.GenerateComponents method within generators/github/package.go. This ensures that YAML documents, particularly CRDs, are cleaned of leading comments (like copyright headers) before parsing, resolving previous parsing errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Darshan174 Darshan174 requested review from lekaf974 and n2h9 November 14, 2025 12:49
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a StripLeadingComments function to handle YAML files with leading comments, like copyright headers, which previously caused parsing errors. The implementation of this new function has a bug where it fails to correctly handle files that consist entirely of comments or empty lines, returning the original content instead of an empty slice. I've provided a fix for this issue. The rest of the changes, which apply this function before parsing CRDs, are correct and well-implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant