Add Connection.get_routing_table() for client-side routing (mgclient 1.6.0)#84
Merged
Conversation
mattkjames7
added
enhancement
mattkjames7
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a low-level Python API for fetching Memgraph HA routing topology by exposing mgclient’s ROUTE primitive as Connection.get_routing_table(...), plus basic validation/bad-state tests.
Changes:
- Add
Connection.get_routing_table(routing_context=None, bookmarks=None, extra=None)implemented in the C extension and returning a Pythondict. - Export
mg_map_to_py_dict()inglue.hfor cross-module reuse and wire up internal error handling for the new call. - Add tests for argument validation and error on invalid connection state.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/test_connection.py | Adds tests for get_routing_table argument validation and invalid connection state. |
| src/glue.h | Exposes mg_map_to_py_dict() so connection.c can convert route results to Python. |
| src/connection.h | Exposes connection_handle_error() prototype for use from connection.c. |
| src/connection.c | Implements Connection.get_routing_table() and registers it on the Python type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
as51340
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the bundled
mgclientsubmodule to 1.6.0 and addsConnection.get_routing_table()for client-side routing.