Add 'onSwipedVertical' and 'onViewTransforming' events - #48
Conversation
So you can detect the exact transform the user is currently applying to the image, and (for example) decrease the opacity of the background if the image is being dragged up
Prevents accidentally triggering event while swiping horizontally
|
Ok, that's it. It's working correctly for me now, I can successfully and easily swipe away a picture to close the gallery. |
|
@Exilz Sorry! I tested it on a real device ( |
|
Can you be a bit more specific? |
|
Any news on this one ? I'd very much like to see it merged 👍 |
|
I tried it as well, and something broke somewhere in my merge. Additionally, I'm starting to think that https://github.com/merryjs/photo-viewer is perhaps a better library for my needs... Only works if your project is ejected already though. |
|
Can you explain what ejected means please ? First time hearing that term. |
|
These guys explain it better than me: https://github.com/react-community/create-react-native-app/blob/master/EJECTING.md |
|
Ah ok! I was aware of that whole CRNA vs Cheers! |
|
For what it's worth, I've now merged the patches correctly and the version at https://github.com/infostreams/react-native-image-gallery/tree/dev is working. It's nowhere near as smooth or nice as the gallery component I linked to above, but it'll do. You can install it as follows
Demo with cropped screen of fake profile page: http://gph.is/2GfhKBW |
|
When is this going to be merged? |
|
Why not to merge it? |
|
plz merge this |
|
@devjiro76 just fork and publish it yourself. No need to wait for the
author.
On Fri, 28 Jun 2019 at 11:07, Devjiro76 ***@***.***> wrote:
plz merge this
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#48>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB23AZPXDKLWO3MB6WC2ERTP4XBF5ANCNFSM4EKWVE4A>
.
--
*Eduard Duluman*
F
ull Stack Developer
SC
FLEXBOX SRL
Tel: +40 748 891 241
*www.duluman.ro <http://www.duluman.ro/>*
|
Can be used to close the gallery by swiping up or down ('onSwipedVertical'), and to lighten the background while dragging up ('onViewTransforming')