Handle invalid bandcamp_item_id files and make ID writes atomic#62
Merged
Conversation
Owner
|
Yep looks fine, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61
Handle invalid
bandcamp_item_id.txtfiles gracefully and make item ID writes more robust.This changes the local media indexer so empty or non-numeric
bandcamp_item_id.txtfiles no longer abort startup. Invalid files are skipped with a warning, while the enclosing album directory is still tracked by name so already-downloaded media is not immediately re-downloaded.It also hardens
bandcamp_item_id.txtwrites by validating the item ID before writing and replacing the file atomically from a temporary file. If writing the ID file fails after media download, sync now logs the error and continues instead of terminating the whole run.Tests added.