Repository navigation
chore(#10606): bump minimum chrome version - #10616
Merged
Merged
Conversation
Bumps the wdio group with 7 updates: | Package | From | To | | --- | --- | --- | | [@wdio/allure-reporter](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-allure-reporter) | `9.20.0` | `9.23.2` | | [@wdio/appium-service](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-appium-service) | `9.20.0` | `9.23.2` | | [@wdio/cli](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-cli) | `9.20.0` | `9.23.2` | | [@wdio/devtools-service](https://github.com/webdriverio/devtools/tree/HEAD/packages/devtools-service) | `8.46.0` | `10.2.0` | | [@wdio/local-runner](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-local-runner) | `9.20.0` | `9.23.2` | | [@wdio/mocha-framework](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-mocha-framework) | `9.20.0` | `9.23.2` | | [@wdio/spec-reporter](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/wdio-spec-reporter) | `9.20.0` | `9.23.2` | Updates `@wdio/allure-reporter` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-allure-reporter) Updates `@wdio/appium-service` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-appium-service) Updates `@wdio/cli` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-cli) Updates `@wdio/devtools-service` from 8.46.0 to 10.2.0 - [Release notes](https://github.com/webdriverio/devtools/releases) - [Commits](https://github.com/webdriverio/devtools/commits/v10.2.0/packages/devtools-service) Updates `@wdio/local-runner` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-local-runner) Updates `@wdio/mocha-framework` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-mocha-framework) Updates `@wdio/spec-reporter` from 9.20.0 to 9.23.2 - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](https://github.com/webdriverio/webdriverio/commits/v9.23.2/packages/wdio-spec-reporter) --- updated-dependencies: - dependency-name: "@wdio/allure-reporter" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio - dependency-name: "@wdio/appium-service" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio - dependency-name: "@wdio/cli" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio - dependency-name: "@wdio/devtools-service" dependency-version: 10.2.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: wdio - dependency-name: "@wdio/local-runner" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio - dependency-name: "@wdio/mocha-framework" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio - dependency-name: "@wdio/spec-reporter" dependency-version: 9.23.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wdio ... Signed-off-by: dependabot[bot] <support@github.com>
…oks, and ensure precise task checks
…x aria selector typo
…chrome-version # Conflicts: # package-lock.json # package.json # tests/e2e/default-mobile/old-navigation/old-navigation.wdio-spec.js
…n' into 10606-bump-minimum-chrome-version
dianabarsan
commented
Mar 3, 2026
| const isEnabled = await this.rulesEngineService.isEnabled(); | ||
| this.tasksDisabled = !isEnabled; | ||
| const taskDocs = isEnabled ? await this.rulesEngineService.fetchTaskDocsForAllContacts() : []; | ||
| this.hasTasks = taskDocs.length > 0; |
Contributor
Author
There was a problem hiding this comment.
This triggered an "expression changed after it was checked" angular error, which only showed up once I ran the tests on the dev build locally. The tests were failing consistently with feedback docs getting created most of the time, and I also replicated it in browser.
The value gets set through the redux flow state, and the display is correct now.
Contributor
Author
|
Hi @witash There was a lot of chatter on this PR. I waited for the new features in 5.1 to land, to resolve conflicts and stabilize those tests. And then I went a little crazy with trying to stabilize some flakiness. There's a lot of commit chatter but very little actual changes. I want to ask you for one final sanity check before I merge. |
witash
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Title is deceptive as this PR does a few more things:
Upgrades wdio to latest
This is a minor release bump, but one dependent package
devtools(used to communicate with the browser) was deprecated in wdio@9 and now it's being reused for something else (????). Dependabot keeps trying to upgrade this deprecated package to the new version and everything fails.The package has a replacement, called
lighthousewhich depends on a new protocol called BiDi - basically a web socket between the test runner and the browser where communication is bidirectional. it's super strong and can achieve waaaay more stuff thandevtools, however it made a lot of our e2e tests unstable or fail, so when we upgraded to wdio@9, we chose to use the legacy protocol (devtools).This PR stabilizes all the tests so we can use BiDi and up to date packages.
Bumping minimum chrome version to 107.
This was relatively straight forward, with some minor tweaks so that tests work both with
chromedriverprotocol andBiDi.Some generic e2e test stabilizing. 🤞🏻
Changing retry protocol
Instead of using mocha retry, which just retried one test, we now use wdio retry, which tries the whole spec.
Updates minimum chrome version in Webapp and in e2e tests
closes #10606
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.