Add interpreter regression tests for joined-column option typing#288
Closed
Add interpreter regression tests for joined-column option typing#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
u8?) and unwrap tou8when matched.| * => 0.) is inferred asf64instead of being coerced to the first arm's integer kind (u8).Description
tests/interpreter.rs(guarded by#[cfg(all(feature = "u8", feature = "u64"))]) that exercise joined-column lookups and option matching.interpret_joined_column_lookup_infers_option_for_present_value,interpret_joined_column_lookup_infers_option_for_missing_value, andinterpret_joined_column_option_match_uses_first_arm_type_for_wildcard_coercion, and they assert expectedu8results via thetest_interpreter!macro.u8.Testing
cargo test --test interpreter interpret_joined_column -- --nocapture, which executed the three new tests.interpret_joined_column_lookup_infers_option_for_present_value,interpret_joined_column_lookup_infers_option_for_missing_value) and one test (interpret_joined_column_option_match_uses_first_arm_type_for_wildcard_coercion) failed, reproducing the reported coercion bug.Codex Task