Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MatrixValueand optional table columns to simplify and optimize access paths.Description
TableJoinFxn::build_joined_tableto mark output columnValueKindasOption(...)for columns coming from the non-preserved side of outer joins and add helpermake_optional_kind.MatrixAccessScalarValueFimplementation withsolve,out,to_stringand acompilerimplementation and use it in theMatrixAccessScalarcompiler when the LHS is aValue::MatrixValueand the index is aValue::Index.impl_access_column_table_fxnto return a swizzle when the requested table column is anOptionvalue to enable direct optional-column access.Testing
tests/interpreter.rsincludinginterpret_table_full_outer_join_marks_sparse_columns_optionaland the optional-column access cases, and they passed.interpret_table_full_outer_join_symbol/interpret_table_full_outer_join_wordand the left/right/inner join tests, and they passed.tests/interpreter.rsand they passed.Codex Task