Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 22 22
Lines 3331 3331
=======================================
Hits 2499 2499
Misses 832 832 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
PR is ready, but we should probably consider adding |
This was referenced Apr 13, 2025
Merged
kanekosh
requested changes
Apr 14, 2025
Contributor
|
@ewu63 yes I think we should install |
Contributor
|
PR for the containers is up https://github.com/mdolab/docker/pull/281. |
Collaborator
Author
|
We can wait for Docker to be updated first, then remove the cyipopt change. |
kanekosh
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds some basic GHA tests, because we do not currently test optional optimizer installation in our docker tests and I want to make sure nothing breaks with 1) optional installation/dependency not breaking, and 2) tests get skipped properly. We should merge this one before #433 to make sure everything looks good with mesonpy.
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable