Closed
Conversation
Closed
3 tasks
marcomangano
approved these changes
Jul 21, 2025
Collaborator
marcomangano
left a comment
There was a problem hiding this comment.
The changes look good to me. This will trigger a series of failures until we update all the downstream repos, correct?
Contributor
|
Yeah, this will trigger failure on pretty much all our repos |
Member
Author
|
Yeah it will. I wonder if we should wait a couple of weeks and make fixing these formatting issues and the associated PRs an MDOLab workshop task. Might be a good introduction to our GitHub process for the new students? |
Member
Author
|
Closing as we switched to ruff for formatting and linting in #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses #70
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable