Fix: Decouple video download quality from playback quality setting #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: fix build process and fastlane
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where changing the Video Download Quality setting would incorrectly update the Video Playback Quality setting. The fix ensures both settings now operate independently.
- Corrected the
setVideoDownloadQualityfunction to call the appropriate dataStore method - Removed redundant nested coroutine scope and incorrect state update call
- The two quality settings are now properly decoupled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug in
SettingsViewModel.ktwhere changing the Video Download Quality setting would incorrectly update the Video Playback Quality setting.Description of changes:
setVideoDownloadQualityfunction to calldataStoreManager.setVideoDownloadQualityinstead ofsetVideoQuality.getVideoQuality()(which refreshed the playback quality state) and ensured onlygetVideoDownloadQuality()is called to update the UI.