feature: Add destroy menubar capability#323
Open
typologist wants to merge 8 commits into
Open
Conversation
|
Hello 👋 |
4 tasks
afonsojramos
added a commit
to gitify-app/menubar
that referenced
this pull request
May 9, 2026
## Summary - Adds a `destroy()` method that removes all tray and app listeners, destroys the underlying `BrowserWindow`, and prevents the window from opening again until a new `Menubar` instance is created. - Adds an `isDestroyed()` accessor reporting the destroyed state. - Refactors `clicked`, `onAppReady`, and `onAppActivate` into arrow-function class fields so they have stable references and can be removed from event emitters by reference. - Documents the new methods in the README. - Adds tests for `destroy()` / `isDestroyed()` and extends the electron mock with `destroy` / `removeListener`. Adapted from the upstream PR [max-mapper#323](max-mapper#323) by @typologist, which fixes [max-mapper#281](max-mapper#281). ## Test plan - [x] `bun run test` — all tests pass - [x] `bun run typecheck` — no errors - [x] `bun run lint:check` — no new warnings (one pre-existing warning unrelated to this PR) - [x] `bun run build` — produces ESM/CJS bundles --------- Co-authored-by: Jimmy <3059814+typologist@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy()method which removes all event listeners and prevents the window from opening after that, until a new instance is createdisDestroyed()method to know the destroyed status of menubarreadmeaccordingly