This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Open
Conversation
Contributor
|
I was able to compile Also, why would you add |
Member
|
Similar issue was fixed in our public form of sapling-crypto some time ago. I think the whole rust-crypto package was removed and updated for specific hashes. It may be better to converge those two repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
franklin-crypto depends on rust-crypto, which in turn depends on rust-serialize, which is deprecated, and can't be compiled into wasm. There is a pull request in rust-crypto which removes the dependency, but since no one maintains the project for years, it doesn't get merged. This is the fork from which the pull request was created: https://github.com/buttercup/rust-crypto-wasm. I changed our dependency to it.