Skip to content

fix(prividium): route page-load failures to a privacy-preserving not-found page#618

Merged
tomimor merged 6 commits into
mainfrom
fix/172-prividium-not-found
Jun 10, 2026
Merged

fix(prividium): route page-load failures to a privacy-preserving not-found page#618
tomimor merged 6 commits into
mainfrom
fix/172-prividium-not-found

Conversation

@tomimor

@tomimor tomimor commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

What ❔

  • In Prividium mode, address/block/token/transaction page loads that fail with a 4xx now land on the existing /not-found page with the copy "Nothing to show. This page may not exist, or it may not be visible to you." instead of a red "Something went wrong" card or the search-style default copy.
image

Why ❔

  • Non-admins navigating to another user's address or blocked pages saw a generic "Something went wrong" that read like a bug, not an expected outcome.

Before:
image

Related: matter-labs/zksync-prividium#172

Note

  • Contact support being hardcoded is currently an existing bug in the not-found page. As this extends to the footer as well, I will address this in a separate PR.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

API E2E Test Results

185 tests   185 ✅  18s ⏱️
 13 suites    0 💤
  1 files      0 ❌

Results for commit 2eba948.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

API Prividium E2E Test Results

9 tests   9 ✅  6s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 2eba948.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Unit Test Results

    4 files    278 suites   10m 9s ⏱️
2 240 tests 2 239 ✅ 1 💤 0 ❌
2 403 runs  2 402 ✅ 1 💤 0 ❌

Results for commit 2eba948.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR:
https://staging-scan-v2-zksyncos--pr-618-khw8c1g2.web.app

@tomimor tomimor marked this pull request as ready for review June 9, 2026 13:13
@tomimor tomimor requested a review from a team as a code owner June 9, 2026 13:13
Comment thread packages/app/src/composables/useAddress.ts Outdated
Comment thread packages/app/src/composables/useBlock.ts
Comment thread packages/app/src/locales/en.json Outdated
…other failures

Addresses review feedback: blanket-swallowing every FetchError sent genuine
errors (400/500) to the not-found page. Now only 403 (not visible) and 404
(missing) route there; other failures keep showing the error page. Applied
consistently across useAddress, useBlock and useTransaction. Also updates the
Prividium not-found copy to mention permissions per review.
@tomimor tomimor requested review from aon and calvogenerico June 10, 2026 11:32
@tomimor tomimor merged commit 564d106 into main Jun 10, 2026
19 checks passed
@tomimor tomimor deleted the fix/172-prividium-not-found branch June 10, 2026 12:58
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants