make static linking io_uring independent from static feature
#1
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not using the cmake build system, tuwunel will just need to specify the
io-uring-staticfeature for therust-rocksdbdependency to enable statically linking io_uring.This was brought up due to Arch Linux and likely other distributions not providing a liburing-dev package with
liburing.aor aliburing-staticpackage,pkg-config::probe_libraryonly looks for shared libraries which is why the build script does not panic earlier, and the default feature/behaviour for rust-rocksdb is to statically link rocksdb and compression libraries.