Skip to content

Remove external CSS dependencies from Parsons iframe and use Moodle theme styles #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpinger wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

Remove external CSS dependencies from Parsons iframe and use Moodle theme styles #1694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions corsscripts/sortable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@import url("https://cdn.jsdelivr.net/npm/bootstrap@5.3.1/dist/css/bootstrap.min.css");
@import url("https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css");
@import url("../styles.css");

body {
Expand Down
2 changes: 1 addition & 1 deletion corsscripts/sortable.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions stack/cas/castext2/blocks/parsons.block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ class stack_cas_castext2_parsons extends stack_cas_castext2_block {

// phpcs:ignore moodle.Commenting.MissingDocblock.Function
public function compile($format, $options): ?MP_Node {
global $PAGE;

$r = new MP_List([new MP_String('iframe')]);

// Define iframe params.
Expand Down Expand Up @@ -149,6 +151,14 @@ public function compile($format, $options): ?MP_Node {
new MP_String('script'),
new MP_String(json_encode(['type' => 'text/javascript', 'src' => $mathjax])),
]);

foreach ($PAGE->theme->css_urls($PAGE) as $themecssurl) {
$r->items[] = new MP_List([
new MP_String('style'),
new MP_String(json_encode(['href' => $themecssurl->out(false)])),
]);
}

$r->items[] = new MP_List([
new MP_String('style'),
new MP_String(json_encode(['href' => $css])),
Expand Down