Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Nov 16, 2025

This PR adjusts the menu items for speech/Braille and hidden MathML so that selecting hidden MathML will turn off speech and Braille, and vice versa. That makes is a little easier to switch the type of assistive support to be used. (It really doesn't make sense to have both speech/braille and assistive MathML on at once in any case.)

@dpvc dpvc requested a review from zorkow November 16, 2025 20:44
@dpvc dpvc added this to the v4.1.0 milestone Nov 16, 2025
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.49%. Comparing base (685a53b) to head (c084317).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1388   +/-   ##
========================================
  Coverage    86.49%   86.49%           
========================================
  Files          340      340           
  Lines        85813    85813           
  Branches      4815     4815           
========================================
  Hits         74220    74220           
  Misses       11593    11593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are using it already in 4 places, would it make sense to move the pretend we're loading hack into a separate method like

function withoutRerendering(exec: () => void) {
  Math.loading++;
  exec();
  Math.loading--;
}

@dpvc
Copy link
Member Author

dpvc commented Nov 20, 2025

I've added the function you requested (I had meant to do something like that and forgot). I also added some text to the help dialog indicating the new menu behavior.

@dpvc dpvc requested a review from zorkow November 20, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants