Skip to content

Fix sg - #1501

Merged
tsmathis merged 3 commits into
mainfrom
fix-sg
Aug 17, 2026
Merged

Fix sg#1501
tsmathis merged 3 commits into
mainfrom
fix-sg

Conversation

@minhsueh

Copy link
Copy Markdown
Collaborator

Fix space group parsing:

  1. Centralize the use of unicodeify_spacegroup from Pymatgen.
  2. Fix htmlify_spacegroup.

Note: Testing is blocked until the corresponding Pymatgen PR is merged.

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (23efcfc) to head (af39197).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
- Coverage   85.14%   85.13%   -0.01%     
==========================================
  Files         230      230              
  Lines       18904    18896       -8     
==========================================
- Hits        16096    16088       -8     
  Misses       2808     2808              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmathis
tsmathis merged commit 45be588 into main Aug 17, 2026
17 checks passed
@tsmathis
tsmathis deleted the fix-sg branch August 17, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants