Skip to content

Update to Angular 8.1.0 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2019
Merged

Update to Angular 8.1.0 #72

merged 3 commits into from
Jul 9, 2019

Conversation

@magneticflux-
Copy link

@magneticflux- magneticflux- commented Jul 6, 2019

Closes #71

@magneticflux-
Copy link
Author

magneticflux- commented Jul 6, 2019

@sante85 Also please remember to update the beta tag on NPM since it's very out of date!

@magneticflux-
Copy link
Author

magneticflux- commented Jul 6, 2019 •
edited
Loading

@sante85 Actually, the Angular library should be specified as a peer dependency. The Angular CLI can also be used here, which would make it easier to maintain. Would you accept a pull request that makes those changes as well?
My draft: #73

@sante85
Copy link
Collaborator

sante85 commented Jul 9, 2019

in next day i do a pr merge

@sante85 sante85 merged commit a6f46dc into masvis:8.x Jul 9, 2019
@magneticflux- magneticflux- deleted the 8.x branch July 9, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@magneticflux- @sante85