Fix behaviors for PicklistItems with no value for SLDS2
#499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
msmx-mnakagawa
force-pushed
the
support-slds-2-fix-picklist-item-behaviors-with-no-value
branch
from
1241371 to
4723f49
Compare
msmx-mnakagawa
changed the title
PicklistItem behaviors with no valuePicklistItems with no value
msmx-mnakagawa
changed the base branch from
support-slds-2-show-picklist-dividers-expectedly
to
master
msmx-mnakagawa
changed the title
PicklistItems with no valuePicklistItems with no value for SLDS2
stomita
requested changes
Oct 30, 2025
stories/Picklist.stories.tsx
Outdated
| onComplete: { action: 'complete' }, | ||
| picklistItem1_onClick: { action: 'picklistItem1_click' }, | ||
| picklistItem2_onClick: { action: 'picklistItem2_click' }, | ||
| picklistItem3_onClick: { action: 'picklistItem3_click' }, |
Collaborator
There was a problem hiding this comment.
Not sure why it added handlers for each picklist items
stories/Picklist.stories.tsx
Outdated
| <PicklistItem | ||
| key='1' | ||
| label='Picklist Item One (No Value)' | ||
| onClick={picklistItem1_onClick} |
Collaborator
There was a problem hiding this comment.
I'm not sure why PicklistItem requires onClick handling test. It should be handled in the Picklist's onSelect or onValueChange event.
Also, it is useless when not setting value in PicklistItem. It is expected to set the value if it handles the selection event.
Collaborator
Author
stomita
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed behaviors for
PicklistItems with no value regardingisFocusedandonClick()What I did
onClick()actions ofPicklistItemto storybook