Skip to content

Blog #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marturi wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Blog #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8d16d5a
Testing sonar PR integration
Oct 21, 2016
8221ff7
pom changes
Oct 21, 2016
db6fbfe
pom changes
Oct 21, 2016
a28a4a2
pom changes
Oct 21, 2016
9948bd1
pom changes
Oct 21, 2016
798fb97
pom changes
Oct 21, 2016
a0c630c
pom changes
Oct 21, 2016
82a2f36
pom changes
Oct 21, 2016
5be5e7f
pom changes
Oct 21, 2016
a9ea64d
pom changes
Oct 21, 2016
7a12d24
pom changes
Oct 21, 2016
b0dca87
pom changes
Oct 21, 2016
708bada
pom changes
Oct 21, 2016
31d9877
pom changes
Oct 21, 2016
30b1bed
pom changes
Oct 21, 2016
2b4f9bf
pom changes
Oct 21, 2016
5b3d57f
pom changes
Oct 21, 2016
e4e87e6
pom changes
Oct 21, 2016
2a77ac3
pom changes
Oct 21, 2016
4d678c8
pom changes
Oct 21, 2016
7f10a2f
pom changes
Oct 21, 2016
a01bc21
pom changes
Oct 21, 2016
b9e9d6f
pom changes
Oct 21, 2016
b35ece4
pom changes
Oct 21, 2016
c41c197
pom changes
Oct 21, 2016
0606861
pom changes
Oct 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions .../java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app-it/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,7 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<configuration>
<!-- The destination file for the code coverage report has to be set to the same value
in the parent pom and in each module pom. Then JaCoCo will add up information in
the same report, so that, it will give the cross-module code coverage. -->
<destFile>${project.basedir}/../target/jacoco-it.exec</destFile>
</configuration>
</plugin>
</plugins>
</build>

<properties>
<sonar.tests>${project.basedir}/target/test-classes</sonar.tests>
</properties>
</project>
5 changes: 4 additions & 1 deletion ...ges/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/app/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,8 @@
<artifactId>app</artifactId>

<name>Java :: JaCoco Multi Modules :: App</name>

<properties>
<sonar.tests>${project.basedir}/target/test-classes</sonar.tests>
<sonar.java.binaries>${project.basedir}/target/classes</sonar.java.binaries>
</properties>
</project>
15 changes: 13 additions & 2 deletions ...d ut-it/combined-ut-it-multimodule-maven-jacoco/app/src/main/java/example/HelloWorld.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package example;

public class HelloWorld {
public class HelloWorld implements Cloneable {
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Add a "clone()" method to this class. rule


public void coveredByUnitTest() {
System.out.println("coveredByUnitTest1");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

Expand All @@ -16,5 +16,16 @@ public void coveredByIntegrationTest() {
public void notCovered() {
System.out.println("notCovered");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

}


public void morenotCovered() {
System.out.println("morenotCovered");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule
MINOR Define a constant instead of duplicating this literal "morenotCovered" 3 times. rule

}

public void morenotCovered2() {
System.out.println("morenotCovered");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

}

public void morenotCovered3() {
System.out.println("morenotCovered");
Copy link
Owner Author

@marturi marturi Oct 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule

}
}
25 changes: 14 additions & 11 deletions ...nguages/java/code-coverage/combined ut-it/combined-ut-it-multimodule-maven-jacoco/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,16 @@
<!-- The destination file for the code coverage report has to be set to the same value
in the parent pom and in each module pom. Then JaCoCo will add up information in
the same report, so that, it will give the cross-module code coverage. -->
<sonar.jacoco.itReportPath>${project.basedir}/../target/jacoco-it.exec</sonar.jacoco.itReportPath>
<sonar.jacoco.reportPath>${user.dir}/target/jacoco.exec</sonar.jacoco.reportPath>
<sonar.java.coveragePlugin>jacoco</sonar.java.coveragePlugin>
<sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
<sonar.language>java</sonar.language>
<sonar.host.url>https://sonar.symphony.com</sonar.host.url>
<sonar.analysis.mode>preview</sonar.analysis.mode>
<sonar.github.pullRequest>2</sonar.github.pullRequest>
<sonar.github.repository>marturi/sonar-examples</sonar.github.repository>
<jacoco.out.path>${user.dir}/target</jacoco.out.path>
<jacoco.out.file>jacoco.exec</jacoco.out.file>
</properties>

<dependencies>
Expand Down Expand Up @@ -59,32 +67,27 @@
<pluginManagement>
<plugins>
<plugin>
<configuration>
<destFile>${jacoco.out.path}/${jacoco.out.file}</destFile>
<append>true</append>
</configuration>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.7.2.201409121644</version>
<version>0.7.4.201502262128</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<configuration>
<append>true</append>
</configuration>
<executions>
<execution>
<id>agent-for-ut</id>
<goals>
<goal>prepare-agent</goal>
</goals>
</execution>
<execution>
<id>agent-for-it</id>
<goals>
<goal>prepare-agent-integration</goal>
</goals>
</execution>
<execution>
<id>jacoco-site</id>
<phase>verify</phase>
Expand Down