Open
Conversation
Owner
|
Nice, I'll take a look as soon as I have the time. |
|
will you fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback would be good, WIP for #50
In the current WIP implementation:
raw_rumble: rumble data arrives, calls the callback with 2 tuples: left rumble data, right rumble data (not sure how this works for joycons)tuple contains of 4 numbers: high frequency, high amplitude, low frequency, low amplitude
what that means, see https://github.com/dekuNukem/Nintendo_Switch_Reverse_Engineering/blob/master/rumble_data_table.md
I do calculate the 0-~200 values into a 0-1 roughly, this is not implemented as in the link
rumble: just calls a function with 2 parameters after a rumble occurs: duration, max amplitude