Fix incorrect page number rendering in uncover theme on PDF rendered by Firefox - #735
Merged
Conversation
… Firefox browser
There are no known rendering issues with Marp's built-in themes in Firefox at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. marp-team/marp-core#424 (comment)
Due to a long standing Firefox bug #1529152, page numbers on
uncovertheme have incorrect PDF rendering if used--browser firefox.In Marp Core v4.4.0, we've shipped a workaround for correct page number rendering on PDF only when enabled
svg.context-properties.content.enabledinabout:config.https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/fill#context-fill_example
Marp CLI enables it for better PDF rendering of
uncovertheme with FIrefox backend.