setup.py: Don't import packages that aren't installed yet.#34
Open
leorochael wants to merge 1 commit intomarinho:masterfrom
Open
setup.py: Don't import packages that aren't installed yet.#34leorochael wants to merge 1 commit intomarinho:masterfrom
leorochael wants to merge 1 commit intomarinho:masterfrom
Conversation
`setup.py` should never attempt to import packages that are not yet installed, including packages from the source it is distributing. In this case, importing `get_version()` from `geraldo.version` was causing `reportlab` to be imported by side-effect (via `geraldo.__init__` which imports `geraldo.graphics`, besides other modules). However there is no guarantee that `reportlab` is already installed when `setup.py` is run, as it is the job of `setup.py` to specify `reportlab` as a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pyshould never attempt to import packages that are not yetinstalled, including packages from the source it is distributing.
In this case, importing
get_version()fromgeraldo.versionwas causingreportlabto be imported by side-effect (viageraldo.__init__whichimports
geraldo.graphics, besides other modules).However there is no guarantee that
reportlabis already installed whensetup.pyis run, as it is the job ofsetup.pyto specifyreportlabas adependency.