Skip to content

fix(DST-1294): remove muted text color from Dialog content slot#5256

Merged
aromko merged 13 commits intomainfrom
fix/DST-1294-dialog-content-text-color
Apr 9, 2026
Merged

fix(DST-1294): remove muted text color from Dialog content slot#5256
aromko merged 13 commits intomainfrom
fix/DST-1294-dialog-content-text-color

Conversation

@sebald
Copy link
Copy Markdown
Member

@sebald sebald commented Apr 1, 2026

Summary

  • Removes text-muted-foreground from the Dialog content slot in theme-rui
  • Dialog body text now inherits the default foreground color instead of being muted
  • Fixes readability issues and removes the need for consumer overrides

Jira

DST-1294

Test plan

  • Verify Dialog content text uses default foreground color
  • Check existing Dialog stories in Storybook for visual regression

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marigold-docs Ready Ready Preview, Comment Apr 9, 2026 2:55pm
marigold-storybook Ready Ready Preview, Comment Apr 9, 2026 2:55pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
marigold-production Ignored Ignored Apr 9, 2026 2:55pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 119c39c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@marigold/theme-rui Patch
@marigold/docs Patch
@marigold/system Patch
@marigold/components Patch
@marigold/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Accessibility tests executed. Download the report here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Coverage Report for Marigold Code Coverage

Status Category Percentage Covered / Total
🔵 Lines 97.16% 1853 / 1907
🔵 Statements 96.55% 1932 / 2001
🔵 Functions 94.51% 500 / 529
🔵 Branches 90.56% 1171 / 1293
File CoverageNo changed files found.
Generated in workflow #20736 for commit 119c39c by the Vitest Coverage Report Action

Comment thread themes/theme-rui/src/components/Dialog.styles.ts
aromko
aromko previously approved these changes Apr 8, 2026
Comment thread themes/theme-rui/src/components/Dialog.styles.ts
@aromko aromko dismissed their stale review April 8, 2026 07:31

See comment

Plain text content without <Text> wrapper ensures the content slot's
text color styling is captured by visual regression tests.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Accessibility tests executed. Download the report here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Accessibility tests executed. Download the report here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Accessibility tests executed. Download the report here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Accessibility tests executed. Download the report here.

@aromko aromko enabled auto-merge (squash) April 9, 2026 14:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Accessibility tests executed. Download the report here.

Comment thread packages/components/src/Dialog/Dialog.stories.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Accessibility tests executed. Download the report here.

@aromko aromko merged commit 5dfb6da into main Apr 9, 2026
14 checks passed
@aromko aromko deleted the fix/DST-1294-dialog-content-text-color branch April 9, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature or component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants