Skip to content

Conversation

@Michaelpalacce
Copy link
Member

No description provided.

@Michaelpalacce Michaelpalacce changed the base branch from main to feature-async-repl-ga October 8, 2025 11:56
@Michaelpalacce Michaelpalacce self-assigned this Oct 8, 2025
@Michaelpalacce Michaelpalacce marked this pull request as ready for review October 8, 2025 11:56
@mmontes11 mmontes11 force-pushed the feature/migration-script-for-25.10.0 branch from 65a9ab5 to 15efd0d Compare October 9, 2025 09:27
@mmontes11 mmontes11 added the replication Asynchronous replication label Oct 9, 2025
mmontes11
mmontes11 previously approved these changes Oct 9, 2025
Copy link
Member

@mmontes11 mmontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Other than that LGTM

Michaelpalacce and others added 3 commits October 9, 2025 14:22
Does an in-file replacement of properties if they are present only.
Creates the changes in a new file rather than modifing the original one.
Will show a nice summary of what was done in the end if `diff` tool exists.

Also extracts the `status` field, but to be fair I don't undertand why this is needed, will leave it for the PR review
@Michaelpalacce Michaelpalacce force-pushed the feature/migration-script-for-25.10.0 branch from b4b5cff to 8133741 Compare October 9, 2025 11:22
@mmontes11 mmontes11 self-requested a review October 13, 2025 07:37
@mmontes11 mmontes11 merged commit f45eb56 into feature-async-repl-ga Oct 13, 2025
7 checks passed
This was referenced Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

replication Asynchronous replication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants