Skip to content

fix: avoid bundling Nitro package metadata - #1641

Open
huytdps13400 wants to merge 1 commit into
margelo:mainfrom
huytdps13400:fix/1619-avoid-package-json-bundle
Open

fix: avoid bundling Nitro package metadata#1641
huytdps13400 wants to merge 1 commit into
margelo:mainfrom
huytdps13400:fix/1619-avoid-package-json-bundle

Conversation

@huytdps13400

Copy link
Copy Markdown

Summary

  • replace the runtime package.json require with the release-synchronized JS version literal
  • extend the existing postversion hook so the JS literal and native NITRO_VERSION macro update together
  • add a regression test and run Nitro Modules package tests in the TypeScript CI workflow

Breaking changes

None. The existing duplicate-install and native/JS version mismatch checks keep using the same package version.

Verification

  • regression failed before the fix because NativeNitroModules.ts imported react-native-nitro-modules/package.json
  • bun nitro test --runInBand: 2 suites passed, 1 new test passed, 1 pre-existing todo
  • bun nitro typecheck
  • bun nitro lint-ci
  • bun nitro build
  • bun run build
  • bun typecheck
  • bun specs, with no generated diff
  • bun nitro write-native-version, with both constants remaining synchronized
  • verified source, CommonJS, and ESM build artifacts contain the version literal and no package.json import
  • C++ and Swift format scripts passed through the Xcode toolchain
  • full lint-all reached Kotlin lint but the local machine does not have the ktlint executable; no Kotlin/native files are changed and CI will run that lane on the configured runner

AI assistance

Codex using GPT-5.6 Sol assisted with reproduction, implementation, tests, and review.

Fixes #1619

@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

@huytdps13400 is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package.json is bundled into applications

1 participant