Repository navigation
Ruby: Preserve Unicode character positions in Ruby extraction - #2783
Open
joelhawksley wants to merge 4 commits into
Open
joelhawksley wants to merge 4 commits into
joelhawksley wants to merge 4 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
documentation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
joelhawksley
marked this pull request as ready for review
October 6, 2026 17:47
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
marcoroth
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working on #2260, I realized that some of the complexity in the implementation came from RuboCop operating on character offsets vs. Herb operating on byte offsets. I think for the public API we can mask non-Ruby text by Unicode character rather than UTF-8 byte.
This PR makes the following changes:
preserve_positions: truemask non-Ruby text by Unicode character rather than UTF-8 byte