Repository navigation
Lexer: Allow an ERB delimiter inside a Ruby string - #2656
Merged
Merged
Conversation
marcoroth
force-pushed
the
erb-delimiter-in-ruby-string
branch
from
September 14, 2026 23:55
c652482 to
54e8f68
Compare
Co-Authored-By: Joel Hawksley <joelhawksley@github.com>
marcoroth
force-pushed
the
erb-delimiter-in-ruby-string
branch
from
September 14, 2026 23:57
54e8f68 to
5e8bdc9
Compare
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
@herb-tools/analysis
@herb-tools/browser
@herb-tools/client
@herb-tools/config
@herb-tools/core
@herb-tools/dev-tools
@herb-tools/formatter
herb-language-server
@herb-tools/highlighter
@herb-tools/language-server
@herb-tools/language-service
@herb-tools/linter
@herb-tools/minifier
@herb-tools/node
@herb-tools/node-wasm
@herb-tools/printer
@herb-tools/rewriter
stimulus-lint
@herb-tools/tailwind-class-sorter
commit: |
marcoroth
enabled auto-merge (squash)
September 15, 2026 00:04
Corpus: this branch (0ba36c5) vs main (a840880)
Measured over 38006 templates from 2 diagnostics changed count
A count can drop because a false positive was fixed, or because a diagnostic is no longer reported when it should be. Worth confirming which. 1 file got a better verdict
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2655, which reached the same behavior through lexer string tracking. This takes the parseability route instead, so the lexer stays free of quote and heredoc state.
Also covers the one case left in #1548,
<% x = '<%' %><%= x %>, now asserted withenforce_erubi_equality.Resolves #1548
Resolves #2655