Repository navigation
Engine: Use Location.zero and Token.from in DebugVisitor - #2053
Merged
Merged
Conversation
marcoroth
enabled auto-merge (squash)
August 7, 2026 00:55
github-actions
Bot
added
ruby
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
marcoroth
force-pushed
the
debug-visitor-location-zero
branch
from
August 7, 2026 01:08
4619940 to
552becc
Compare
marcoroth
force-pushed
the
debug-visitor-location-zero
branch
from
August 7, 2026 01:08
552becc to
94e1a16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates
Herb::Engine::DebugVisitorto use the sharedHerb::Location.zeroandHerb::Token.fromconstructors instead of its own local helpers.DebugVisitorpredates those constructors, so it carried three private helpers to build the synthetic nodes.