Repository navigation
Linter: Fix erb-no-trailing-whitespace autofix inside HTML tags - #2016
Merged
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
marcoroth
marked this pull request as ready for review
August 5, 2026 16:07
marcoroth
force-pushed
the
erb-no-trailing-whitespace-inside-tags
branch
from
August 5, 2026 16:10
4922729 to
b566eed
Compare
marcoroth
marked this pull request as draft
August 5, 2026 16:16
marcoroth
force-pushed
the
erb-no-trailing-whitespace-inside-tags
branch
from
August 6, 2026 09:43
b566eed to
4dac354
Compare
marcoroth
marked this pull request as ready for review
August 6, 2026 09:47
marcoroth
enabled auto-merge (squash)
August 6, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates
erb-no-trailing-whitespaceso its autofix also applies to trailing whitespace inside HTML tags, which it previously reported but could never fix.The rule flags trailing whitespace anywhere in the source, but the autofix only knew how to rewrite
HTMLTextNodeandLiteralNodecontent.Whitespace between attributes, after a tag name, or before a tag closing is tracked as a dedicated
WhitespaceNode, sofindNodeAtPositionreturnednullfor those offenses, they were created without anautofixContext, andautofix()bailed on its first line. The offense was reported as[Correctable]and counted inN autocorrectable using --fix, but running--fixchanged nothing and printed the same line again.Everything inside tag markup was affected, while text content and attribute values already worked:
Related #1697 and #1909, which is the same class of misleading
[Correctable]reporting for offenses--fixwill not apply.