Repository navigation
Formatter: Preserve inline whitespace in ERB branches - #2015
Merged
Merged
Conversation
marcoroth
marked this pull request as ready for review
August 5, 2026 12:29
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the formatter silently deleting whitespace between text and ERB tags when that text sits inside an
else,elsif,when,in,rescueorensurebranch.Found while adopting the formatter on RubyEvents in rubyevents/rubyevents#2013
Minimal reproduction:
Before
After
No nesting is required, any text node touching an ERB tag inside a branch loses its edge whitespace. The same input in the
ifbranch was always formatted correctly, which is what made this hard to spot.