Repository navigation
Playground: Throttle URL updates to avoid replaceState limit - #2013
Merged
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the playground to throttle its URL updates so that typing quickly in the editor no longer trips the browser's
history.replaceState()rate limit.Every keystroke called four separate URL writers. Each of them built its own
URLand unconditionally calledwindow.parent.history.replaceState(), even when the search params were already identical to what was in the URL. That adds up to fourreplaceState()calls per keystroke, so Safari's limit of 100 calls per 10 seconds is reached after roughly 25 characters of fast typing:Because the
SecurityErroris thrown from insideupdateURL(), which is the first thinganalyze()does, the rejection aborts the whole analysis and the playground stops responding to further input.