Repository navigation
Linter: Implement actionview-no-unused-strict-locals rule - #2012
Merged
Merged
Conversation
marcoroth
marked this pull request as ready for review
August 5, 2026 11:04
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the
actionview-no-unused-strict-localsrule, which reports locals declared in a<%# locals: (...) %>declaration that the partial never references.A strict locals declaration is the contract of a partial. Every name in it tells callers "this partial needs this value", and Rails raises
ActionView::StrictLocalsErrorwhen a caller passes anything that is not declared. A name the template never reads makes that contract lie: callers keep computing and passing a value that is thrown away, and readers have to search the whole template before they can be sure it is unused. These usually appear when a partial gets refactored, the markup that used the value moves elsewhere, and the declaration stays behind.The message varies with whether the local is required, so an optional local reads
Callers can pass size: ...instead.Resolves #1566