Repository navigation
Linter: Implement actionview-no-unnecessary-html-safe rule - #2007
Merged
Merged
Conversation
github-actions
Bot
added
documentation
marcoroth
marked this pull request as ready for review
August 5, 2026 02:32
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
marcoroth
added a commit
that referenced
this pull request
Aug 5, 2026
Follow up on #2007. `erb-no-unsafe-raw` flags every `.html_safe` call in an ERB output tag with: ``` Avoid `.html_safe` in ERB output. It bypasses HTML escaping and can cause cross-site scripting (XSS) vulnerabilities. ``` That is not true when `.html_safe` is called directly on a String literal. The content is static, so there is no value that escaping could ever apply to and nothing that could carry injected input: ```html+erb <div <%= 'style="display: none;"'.html_safe %>></div> <p><%= "<strong>Sale</strong>".html_safe %></p> ``` Since #2007 those templates are already reported by `actionview-no-unnecessary-html-safe`, which points out that the content belongs in the template directly and offers an autocorrection for it. Until now both rules reported the same tag and only one of the two messages was accurate. This pull request therefore makes `erb-no-unsafe-raw` skip `.html_safe` calls whose receiver is a plain `StringNode`.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a new
actionview-no-unnecessary-html-saferule that flags ERB output tags which consist of nothing but a String literal with.html_safecalled on it.Resolves #1876