Repository navigation
Config: Don't validate the options under the engine key - #2000
Merged
Merged
Conversation
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates
@herb-tools/configandherb-configto accept theenginesection as an opaque mapping, so that engine options shipped by the gem don't makeherb-lintandherb-formatreject the configuration file.Both the JavaScript and the Rust config implementations mirrored the engine options and validated them strictly, even though neither of them ever reads anything under
engine.That section is only consumed by
Herb::Engineon the Ruby side, whereHerb.configuration.engine_option(key, default)is a free-form lookup that doesn't validate keys at all. The result was that any engine option the gem gained had to be added to two more schemas, in two more languages, and released in lockstep before it could be used.Resolves #1994