Repository navigation
Linter: Add support for as: in actionview-prefer-collection-render - #1997
Merged
Merged
Conversation
marcoroth
marked this pull request as ready for review
August 4, 2026 18:52
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
actionview-prefer-collection-renderlinter rule so the replacement it reports keeps working when the loop passes the element under a name that isn't the partial name.The rule reports the exact tag to paste over the loop, and it built that tag from the receiver and the partial alone. Collection rendering names the local after the partial, so any local named something else was silently dropped from the suggestion:
Following that advice hands
_gem_card.html.erbagem_cardlocal, while the partial still readstopic_gem, so the page raisesundefined local variable or method 'topic_gem'. The suggestion now compares the local's key against the name collection rendering would use and appendsas:when the two differ:That implicit name is the last path segment of the partial, so a nested partial whose local already matches keeps the shorter form and doesn't grow a redundant
as::Both spellings of the local are covered, the explicit
locals:hash and the shorthandrender "gem_card", topic_gem: topic_gem. The object shorthand (render userinside the loop) is unaffected, sincerender @userscarries no local name to rename.When the parser reports a local without a name, the rule now stays silent instead of reporting a replacement it can't verify.
Resolves #1981