Skip to content

Rust: Also run make test without --all-features - #1975

Merged
marcoroth merged 1 commit into
mainfrom
use-all-features-in-test
Aug 3, 2026
Merged

marcoroth merged 1 commit into
mainfrom
use-all-features-in-test

Conversation

@marcoroth

@marcoroth marcoroth commented Aug 3, 2026 •

Copy link
Copy Markdown
Owner

Follow up on #1952.

That pull request left the crate with two meaningfully different library builds: the default one, where style::Colorize is a macro-generated passthrough, and the color one, where it re-exports colored::Colorize. make test only ever ran the second.

@github-actions

github-actions Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit 26d4999


✅ Preview deployment has been cleaned up.

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown
npx https://pkg.pr.new/@herb-tools/formatter@1975
npx https://pkg.pr.new/@herb-tools/language-server@1975
npx https://pkg.pr.new/@herb-tools/linter@1975

commit: 26d4999

@marcoroth
marcoroth marked this pull request as ready for review August 3, 2026 13:24
@marcoroth
marcoroth merged commit a1ac935 into main Aug 3, 2026
35 of 36 checks passed
@marcoroth
marcoroth deleted the use-all-features-in-test branch August 3, 2026 13:24

This branch was successfully deployed

1 active deployment
herb-tools (Preview) — 26d49994 Deployed Aug 3, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Rust bindings and the Herb Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant