Provide a unique output dir per set of source files.#23
Open
criemen wants to merge 1 commit intomarcohu:masterfrom
Open
Provide a unique output dir per set of source files.#23criemen wants to merge 1 commit intomarcohu:masterfrom
criemen wants to merge 1 commit intomarcohu:masterfrom
Conversation
This is an attempt to make multiple rules_antlr invocations work without sandboxing (eg on Windows, where there's no sandbox). Test with --spawn_strategy=local.
|
@criemen FYI it has been merged at albertocavalcante#28 |
Author
|
@albertocavalcante Thanks for the ping! It's great to see some traction on this ruleset, it'd be awesome if it (eventually) would find its way to the BCR 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to make multiple rules_antlr invocations work without sandboxing (eg on Windows, where there's no sandbox). Test with --spawn_strategy=local.
Before, the AntlrRules.java code would fail, as it'd find generated grammar files without sandboxing it didn't know about.
Fix this by providing a unique directory per grammar that's being compiled.
The code that throws the exception is https://github.com/marcohu/rules_antlr/blob/master/src/main/java/org/antlr/bazel/AntlrRules.java#L619.