Open
Conversation
Contributor
radudum10
commented
Sep 11, 2022
- pre-commit
- black
- markdownlint-cli
razvand
requested changes
Sep 18, 2022
Member
razvand
left a comment
There was a problem hiding this comment.
Hi, @radudum10 , thanks for this.
Some comments:
- Please use your full name in commits, i.e.
Radu Dumitru <radudum05@gmail.com>. You can usegit commit --amendto fix a commit andgit rebase -i <parent_commit_id>to rebase to a particular commit. - Enhance the commit messages. For example the
Add config file (with hooks)could be renamed toAdd pre-commit configurationfollowed by a detailed description of pre-commit support. - Split the update
README.mdPR and add the part of theREADME.mdtalking aboutpre-committo the commit above. - Follow the Markdown guidelines for
README.md. Particularly, be sure to have one (and only one) full sentence per line. - See the issues reported by the automated checks from GitHub actions in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.