Fix initial send failures being ignored if fallback is disabled #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210
The diff is quite large but when you filter out the whitespace changes it is quite simple:
The
if ($isFallbackNeeded && $isFallbackEnabled === 'yes') {
check is not exhaustive of all the possibilities so when a fallback is needed, but not enabled it falls through to the default return value oftrue
at the bottom of the function which is incorrect. To address this I've:true
it no fallback is needed.false
if a fallback is needed but disabled.I've also removed the fall through
return true
at the end of the function as it is now unreachable.