fix: use ^8.2 PHP constraint for v2.x line#37
Open
CybotTM wants to merge 1 commit intomagicsunday:masterfrom
Open
fix: use ^8.2 PHP constraint for v2.x line#37CybotTM wants to merge 1 commit intomagicsunday:masterfrom
CybotTM wants to merge 1 commit intomagicsunday:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>=8.2.0 <8.5.0to^8.2for the v2.x lineContext
The SDK
netresearch/sdk-api-universal-messengerrequiresmagicsunday/jsonmapper: ^2.4.0. Since v2.4.0 hasphp: >=8.2.0 <8.5.0, it blocks PHP 8.5 installations.There is no
2.xmaintenance branch, so this PR is based on the2.4.0tag. To release a fix:2.xbranch from the2.4.0tag2.4.1Using
^8.2avoids needing a new release for every minor PHP version. There is no technical reason to restrict the upper bound within the 8.x series.See also: PR #36 for the same fix on the v3 (master) line.