Skip to content

Conversation

@magico13
Copy link
Owner

@magico13 magico13 commented Jun 5, 2025

This pull request introduces updates to versioning, dependency requirements, and enhancements to the pyemvue library's device channel handling. The changes include adding support for a new attribute, parentChannelNum, across multiple methods and classes, as well as updating dependencies and version numbers.

Updates to pyemvue library:

  • Version bump: Updated the version in pyemvue/__version__.py from 0.18.8 to 0.18.9.
  • Device channel enhancements:
    • Added a new attribute, parent_channel_num, to the DeviceChannel class in pyemvue/device.py. This includes initializing it in the constructor (__init__), populating it from JSON in from_json_dictionary, and including it in the dictionary representation in as_dictionary. [1] [2] [3]
    • Updated the SimulatorChannel class in simulator/models.py to include the parentChannelNum attribute as an optional string.

Dependency updates:

  • Updated the pycognito dependency version in pyproject.toml from >=2024.2.0 to >=2024.5.0.

@magico13 magico13 requested a review from Copilot June 5, 2025 01:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the library to v0.18.9 by adding support for a new parentChannelNum attribute across device and simulator models, and bumps a dependency requirement.

  • Adds parent_channel_num in DeviceChannel (init, JSON parsing, dict output)
  • Exposes parentChannelNum in SimulatorChannel
  • Bumps pycognito dependency and version number

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
simulator/models.py Expose parentChannelNum on SimulatorChannel
pyproject.toml Update pycognito requirement and other deps
pyemvue/device.py Initialize, parse, and serialize parent_channel_num
pyemvue/version.py Bump version to 0.18.9
Comments suppressed due to low confidence (1)

pyemvue/device.py:161

  • Consider adding unit tests for parsing and serializing parentChannelNum in DeviceChannel.from_json_dictionary and as_dictionary to ensure the new attribute behaves as expected.
if "parentChannelNum" in js:

@magico13 magico13 merged commit 9aa85c5 into master Jun 5, 2025
4 checks passed
@magico13 magico13 deleted the 2025-06-04 branch June 5, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants