Skip to content

Conversation

gexxx05
Copy link

@gexxx05 gexxx05 commented Sep 16, 2025

This fixes the incorrect free_shipping flag for virtual products described in #40184

Description (*)

The fix resets the billing address free_shipping flag in the same way it is done for the shipping address.

Fixed Issues (if relevant)

  1. Fixes Incorrect free_shipping flag for virtual products #40184

Manual testing scenarios (*)

  1. Go through steps to reproduce from issue, on step 8 the free_shipping flag for item test2 is 1 after adding this fix.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

Copy link

m2-assistant bot commented Sep 16, 2025

Hi @gexxx05. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@gexxx05 gexxx05 force-pushed the fix-free-shipping-flag branch from 9f79055 to 429b340 Compare September 17, 2025 06:15
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 17, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Incorrect free_shipping flag for virtual products
2 participants