Skip to content

Updated calibrate.py #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njezersek merged 48 commits into from
Apr 3, 2023
Merged

Updated calibrate.py #849

njezersek merged 48 commits into from
Apr 3, 2023

Conversation

@njezersek
Copy link
Contributor

@njezersek njezersek commented Nov 21, 2022

No description provided.

saching13 and others added 30 commits August 9, 2022 10:17
@saching13
Added WIP Image Align for visualization
186abae
@saching13
Working calibration with SYnc
5113b6b
@saching13
added board config files
fcc4f4c
@saching13
Updated the ar0234 res
e52e734
@saching13
Updated mono in json
562d331
@saching13
Added Output Scale factor and removed the orientation check
d9105b1
@saching13
Fixed the osf
48cdb67
@saching13
Fixed capture issue with different names
f177b01
@saching13
updated links translation
507ede9
@saching13
WIP structure and vertical Stereo calibration
46f8b1f
@saching13
Fixed flashing issues
03766f3
@saching13
updatec req condfitions
84dd899
@saching13
added exception msg
16f6e28
@saching13
removed try catch and writing board names
7b81117
@saching13
adding rect data
1b356df
@saching13
Updated rectification flash
64d5828
@saching13
Removed comments
c9bc18e
@saching13
Added rotation to polygons
38e6102
@saching13
Polygon flex (#789)
861f9e3 
* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel
@saching13
Modified the board file
00acebb
@saching13
added debugs
63b5adb
@saching13
tweaked intrinsics in use
7372329
@saching13
iterative method added but commented
085b4a6
@saching13
cleanedup image sizes and better ep errors
6d3964a
@daxoft
adapt calib script to main depthai
e959a06
@saching13
Fixed config error
1067cb2
@saching13
changed to features in calibration
7091b7d
@saching13
adjust horizontal values
aebdb17
@saching13
Tuning calibration testing epipolar error
eb13e6f
@daxoft
oak-d-sr calibration
f98e1a2
@saching13 saching13 marked this pull request as ready for review December 13, 2022 10:13
@saching13 saching13 requested a review from themarpe December 13, 2022 10:14
themarpe
themarpe requested changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with OAK-D Lite and move resources/boards to reference the depthai-boards as submodule

themarpe and others added 4 commits December 23, 2022 02:49
@themarpe
Added OAK-D-LR support
a8024fa
@daxoft
add oak-d-cm4-c11 calibration file
fa57c7d
@themarpe
Add support for IMX296 camera
795f7e7
@njezersek
Check if markers were detected on undistorted image (#927)
eec047a 
* Added a check to detect if there were no markers found on the undistored image

* Added an error if no markers are found in more than 2 images
@Erol444 Erol444 mentioned this pull request Mar 10, 2023
Open
@Erol444 Erol444 requested review from saching13 and themarpe March 12, 2023 13:14
@Erol444
Copy link
Contributor

Erol444 commented Mar 12, 2023

Can we merge this? @njezersek @saching13

@saching13
Copy link
Contributor

saching13 commented Mar 27, 2023

#843
We could have just merged this one right ? @njezersek

@njezersek
Copy link
Contributor Author

njezersek commented Mar 28, 2023

OAK-D-LITE has very different focus distance [m] to lens position mapping than other cameras. Therefore I changed the default lens position for OAK-D-LITE to 25 (based on trying several different values and comparing the results). Default lens position for other cameras is still 135.

themarpe
themarpe approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@njezersek @themarpe
Modular calibration lr (#984)
0c32f0d 
* Further OAK-D-LR modifications

* Added fixed exposure and wb

* Further LR improvements, mainly synchronization related

* Fixed some issues and tweaked streaming for LR a bit

* Modified default queue depth to 4

* Added missing scipy dependency

* Fixed HFOV for OAK-D-LR

* Fix misplaced parameters for MessageSync

* Exposed 'flashing' stage/mode to be separate from 'process'

* Varius bug fixes

* Fix missing dest_path, fix AR0234 mono resolution

* Set ISP scale for AR0234

---------

Co-authored-by: Martin Peterlin <[email protected]>
Co-authored-by: Matevz Morato <[email protected]>
Co-authored-by: TheMarpe <[email protected]>
@njezersek njezersek merged commit 7cc38f3 into main Apr 3, 2023
@njezersek njezersek deleted the modular-calibration branch April 3, 2023 07:45
@engrmusawarali71
Copy link

engrmusawarali71 commented Feb 10, 2025 •
edited
Loading

Hello! The current script calibrate.py still shows lens position as 135. I am trying to calibrate OAK-D-Lite but images are blurry with 135. I wanted to know what should be exact and correct value @njezersek @saching13

@themarpe
Copy link
Collaborator

themarpe commented Feb 10, 2025

CC: @MaticTonin ^

@engrmusawarali71
Copy link

engrmusawarali71 commented Feb 10, 2025 •
edited
Loading

Thanks @MaticTonin, I am wondering why the images are blur if the focus range is set to >60. Is it the limitation of OAK- D-Lite? @themarpe

@themarpe
Copy link
Collaborator

themarpe commented Feb 11, 2025

@engrmusawarali71 - the range can vary between devices. Certain devices have image in focus at certain ranges of lensPositions and other at different.

@engrmusawarali71
Copy link

engrmusawarali71 commented Feb 11, 2025

@themarpe Thank you, I was wondering if something is wrong with the device or there is some fault.

@engrmusawarali71 engrmusawarali71 mentioned this pull request Feb 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themarpe themarpe themarpe approved these changes

@saching13 saching13 Awaiting requested review from saching13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@njezersek @Erol444 @saching13 @engrmusawarali71 @themarpe @daxoft