Conversation
…effect of ordering on commodity pricing
Owner
Author
|
Currently SSH server is down so unable to make progress - will fix tests once it is back up (I had to refactor lots of the structs, which is why they are failing) |
Archii0
approved these changes
Jan 11, 2026
Archii0
left a comment
Collaborator
There was a problem hiding this comment.
Had a quick skim through, things look pretty good.
Just remember to add new lines at the end of the files (nitpick).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Price-time Priority Exchange
CSV Writing
Further features
Fixes