Conversation
310f6fe to
cbde2de
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds publishing capabilities for the Kuberesolver Java library. The changes include new Javadoc documentation for model classes, Gradle publishing task configurations, and a new GitHub Actions workflow to publish the artifact.
- Added detailed Javadoc comments to model records and enums to improve code documentation.
- Configured new Gradle publishing tasks and added a Maven publication setup.
- Introduced a GitHub Actions workflow to automate artifact publication on release.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/main/java/io/github/lothar1998/kuberesolver/kubernetes/model/*.java | Added Javadoc documentation for records and enums. |
| lib/build.gradle | Configured publishing tasks and Maven publication settings. |
| .github/workflows/publish.yml | Introduced a new workflow for publishing the artifact. |
| lib/src/main/java/io/github/lothar1998/kuberesolver/KubernetesNameResolver*.java | Updated Javadoc formatting for clarity. |
| lib/src/main/java/io/github/lothar1998/kuberesolver/SecureEndpointSliceWatcher.java | Added Javadoc comments to interface methods. |
Files not reviewed (1)
- .idea/.gitignore: Language not supported
Comments suppressed due to low confidence (2)
lib/src/main/java/io/github/lothar1998/kuberesolver/kubernetes/model/Event.java:12
- [nitpick] Consider clarifying in the Javadoc that the parameter 'endpointSlice' maps to the JSON property 'object' to avoid potential confusion.
public record Event(@JsonProperty("type") EventType type, @JsonProperty("object") EndpointSlice endpointSlice) {
lib/src/main/java/io/github/lothar1998/kuberesolver/KubernetesNameResolver.java:51
- [nitpick] The removal of closing paragraph tags in the Javadoc is noted; ensure that the new formatting is consistent across all Javadoc comments in the codebase.
- * </p>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.