Skip to content

Comments

Publishing Artifact#3

Merged
lothar1998 merged 3 commits intomasterfrom
publishing-artifact
May 11, 2025
Merged

Publishing Artifact#3
lothar1998 merged 3 commits intomasterfrom
publishing-artifact

Conversation

@lothar1998
Copy link
Owner

No description provided.

@lothar1998 lothar1998 force-pushed the publishing-artifact branch from 310f6fe to cbde2de Compare May 11, 2025 18:53
@lothar1998 lothar1998 requested a review from Copilot May 11, 2025 18:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds publishing capabilities for the Kuberesolver Java library. The changes include new Javadoc documentation for model classes, Gradle publishing task configurations, and a new GitHub Actions workflow to publish the artifact.

  • Added detailed Javadoc comments to model records and enums to improve code documentation.
  • Configured new Gradle publishing tasks and added a Maven publication setup.
  • Introduced a GitHub Actions workflow to automate artifact publication on release.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/src/main/java/io/github/lothar1998/kuberesolver/kubernetes/model/*.java Added Javadoc documentation for records and enums.
lib/build.gradle Configured publishing tasks and Maven publication settings.
.github/workflows/publish.yml Introduced a new workflow for publishing the artifact.
lib/src/main/java/io/github/lothar1998/kuberesolver/KubernetesNameResolver*.java Updated Javadoc formatting for clarity.
lib/src/main/java/io/github/lothar1998/kuberesolver/SecureEndpointSliceWatcher.java Added Javadoc comments to interface methods.
Files not reviewed (1)
  • .idea/.gitignore: Language not supported
Comments suppressed due to low confidence (2)

lib/src/main/java/io/github/lothar1998/kuberesolver/kubernetes/model/Event.java:12

  • [nitpick] Consider clarifying in the Javadoc that the parameter 'endpointSlice' maps to the JSON property 'object' to avoid potential confusion.
public record Event(@JsonProperty("type") EventType type, @JsonProperty("object") EndpointSlice endpointSlice) {

lib/src/main/java/io/github/lothar1998/kuberesolver/KubernetesNameResolver.java:51

  • [nitpick] The removal of closing paragraph tags in the Javadoc is noted; ensure that the new formatting is consistent across all Javadoc comments in the codebase.
   - * </p>

@lothar1998 lothar1998 merged commit e1efea3 into master May 11, 2025
2 checks passed
@lothar1998 lothar1998 deleted the publishing-artifact branch May 11, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant