Skip to content

Conversation

@darknos
Copy link
Contributor

@darknos darknos commented May 8, 2021

add base transaction support for for mongodb v4+ shard and replica sets

Tests were copied from https://github.com/strongloop/loopback-connector/blob/master/test/transaction.test.js but skip by default, because we need replica set for tests.

I use run-rs for testing

run-rs -v 4.2.0 --host localhost --portStart 27000

just remove .skip from test/transaction.test.js to run it

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@darknos darknos changed the title feat: add transactions support for mongodb v4+ shard and replica sets feat: add transactions support May 8, 2021
@darknos darknos mentioned this pull request May 8, 2021
@dhmlau
Copy link
Member

dhmlau commented May 10, 2021

@darknos, thanks for the PR. Could you please add tests as well? Thanks.

@darknos
Copy link
Contributor Author

darknos commented May 10, 2021

@dhmlau added. (I missed the file when comiited last time)

@darknos
Copy link
Contributor Author

darknos commented May 31, 2021

@darknos, thanks for the PR. Could you please add tests as well? Thanks.

any news?

@taicho
Copy link

taicho commented Jun 1, 2021

@dhmlau Also looking for news on this...

Copy link

@marioestradarosa marioestradarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure if there was a chai feature you required that mocha doesn't have it.

Copy link

@marioestradarosa marioestradarosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darknos great Job, many thanks for this PR. I only had two minor comments about the chai-as-promise package. I fetched your PR locally in my machine and all works perfectly without these two references for this package.

Also, please squash your commits to keep the history tidy and easier to digest.

@darknos darknos requested review from marioestradarosa and removed request for emonddr, hacksparrow and jannyHou July 18, 2021 10:09
@darknos
Copy link
Contributor Author

darknos commented Jul 18, 2021

@marioestradarosa Hi, could you help to understand what the problem with PR Builder?

I did all requested changes but don't have access to Jenkins to check the problem

@achrinza
Copy link
Member

Hi @darknos, apologies for not noticing your query earlier.

As part of LoopBack 4 joining the OpenJS Foundation, we're in the midst of migrating the CI infrastructure from Jenkins to GitHub Actions and Travis CI.

Let me see if I can sort it out from my end and get back to you.

@achrinza achrinza closed this Jul 29, 2021
@achrinza achrinza mentioned this pull request Jul 29, 2021
5 tasks
@achrinza
Copy link
Member

achrinza commented Jul 29, 2021

Yikes! That wasn't supposed to happen... Really sorry about that 🙇

I've re-pushed the commit under #633 as an interim.

If you have a local copy, feel free to force re-push it to reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants