-
Notifications
You must be signed in to change notification settings - Fork 241
feat: add transactions support #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@darknos, thanks for the PR. Could you please add tests as well? Thanks. |
|
@dhmlau added. (I missed the file when comiited last time) |
any news? |
|
@dhmlau Also looking for news on this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so sure if there was a chai feature you required that mocha doesn't have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darknos great Job, many thanks for this PR. I only had two minor comments about the chai-as-promise package. I fetched your PR locally in my machine and all works perfectly without these two references for this package.
Also, please squash your commits to keep the history tidy and easier to digest.
|
@marioestradarosa Hi, could you help to understand what the problem with PR Builder? I did all requested changes but don't have access to Jenkins to check the problem |
|
Hi @darknos, apologies for not noticing your query earlier. As part of LoopBack 4 joining the OpenJS Foundation, we're in the midst of migrating the CI infrastructure from Jenkins to GitHub Actions and Travis CI. Let me see if I can sort it out from my end and get back to you. |
|
Yikes! That wasn't supposed to happen... Really sorry about that 🙇 I've re-pushed the commit under #633 as an interim. If you have a local copy, feel free to force re-push it to reopen this PR. |
add base transaction support for for mongodb v4+ shard and replica sets
Tests were copied from https://github.com/strongloop/loopback-connector/blob/master/test/transaction.test.js but skip by default, because we need replica set for tests.
I use run-rs for testing
just remove
.skipfrom test/transaction.test.js to run itChecklist
npm testpasses on your machine