Add copy_file_range strategy to create database #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pweldon
reviewed
Mar 20, 2025
pweldon
left a comment
pweldon
left a comment
There was a problem hiding this comment.
Will the createdb command need to be updated to support the new strategy?
jodiew
force-pushed
the
template_strategy_reflink
branch
from
9e5b3b5 to
f07f044
Compare
jodiew
commented
Mar 20, 2025
| * Method is either a simple copy or a call to copy_file_range. | ||
| */ | ||
| void | ||
| copydir_with_method(const char *fromdir, const char *todir, bool recurse, CopyMethod copy_method) |
Author
There was a problem hiding this comment.
Just renamed and made a wrapper so that the other places copydir is called isn't affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.