Skip to content

replace raw subprocess calls with unified Executor on bash implementa… #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marwin1991 merged 1 commit into from
Feb 9, 2026
Merged

replace raw subprocess calls with unified Executor on bash implementa… #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/common/executor_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import subprocess
import unittest
from unittest.mock import patch, MagicMock
import subprocess

from valhalla.common.executor import Executor


class ExecutorTest(unittest.TestCase):

@patch('subprocess.run')
Expand All @@ -21,7 +23,7 @@ def test_run_success(self, mock_run):
self.assertEqual(result.returncode, 0)
self.assertEqual(result.stdout, "output")
self.assertEqual(result.stderr, "")
mock_run.assert_called_once_with("ls", shell=True, check=True, capture_output=True, text=True)
mock_run.assert_called_once_with("ls", shell=True, executable='/bin/bash', check=True, capture_output=True, text=True)

@patch('subprocess.run')
def test_run_error(self, mock_run):
Expand Down
Loading